Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add params scene, mesh to function getAttributes #12668

Merged
merged 3 commits into from Jun 21, 2022

Conversation

BlakeOne
Copy link
Contributor

@BlakeOne BlakeOne commented Jun 20, 2022

For the class MaterialPluginBase, add params scene and mesh to the function getAttributes so that they can be used to determine which attributes to use.

Forum: https://forum.babylonjs.com/t/using-custom-attribute-with-material-plugin/31142/7

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if it should be the mesh or submesh here ?

@BlakeOne
Copy link
Contributor Author

BlakeOne commented Jun 20, 2022

should be the mesh or submesh here ?

Hmm I assumed it should be the mesh because that's what prepareDefines passes. For me I would just want to be able to check the mesh to see what attributes it has and maybe check properties on it as well. But maybe it would be good to have the subMesh also thou?

@sebavan sebavan requested a review from Popov72 June 20, 2022 21:51
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan merged commit 2746fca into BabylonJS:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants