Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ExtrudeShape* options firstNormal and adjustFrame #12659

Merged
merged 9 commits into from Jun 21, 2022
Merged

Adds ExtrudeShape* options firstNormal and adjustFrame #12659

merged 9 commits into from Jun 21, 2022

Conversation

Lowclouds
Copy link
Contributor

firstNormal option allows one to pick the first normal of the underlying Path3D path, preventing, in some cases degenerate extrusions.
adjustNormal option causes the underlying Path3D frame of tangents, normals, and binormals to be patched up when the they are either undefined (0,0,0) or reverse direction. This is useful for paths that reverse back on themselves.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@Lowclouds
Copy link
Contributor Author

Lowclouds commented Jun 16, 2022

This playground snippet, https://playground.babylonjs.com/?snapshot=refs/pull/12659/merge#5ICT41#4, tests these new features - except for instances. I haven't used instances, yet

@sebavan sebavan requested a review from RaananW June 16, 2022 14:27
@Lowclouds
Copy link
Contributor Author

I have a more compact and idiomatic, but functionally identical version

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Most of my comments are about reusability of the vector class's functions, so keep the code a little cleaner.

packages/dev/core/src/Meshes/Builders/shapeBuilder.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Meshes/Builders/shapeBuilder.ts Outdated Show resolved Hide resolved
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan merged commit 493810b into BabylonJS:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants