Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix where canvas could have a blue highlight effect on tap. #12635

Merged
merged 2 commits into from Jun 6, 2022
Merged

Fix where canvas could have a blue highlight effect on tap. #12635

merged 2 commits into from Jun 6, 2022

Conversation

saaratrix
Copy link
Contributor

For #12634.

Added a line to also disable the webkitTapHighlight when touch actions are disabled.

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12635/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12635/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12635/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12635/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12635/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12635/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12635/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12635/merge#BCU1XR#0

deltakosh
deltakosh approved these changes Jun 5, 2022
View reviewed changes
Copy link
Contributor

@deltakosh deltakosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@deltakosh deltakosh enabled auto-merge (squash) June 5, 2022 17:03
auto-merge was automatically disabled June 6, 2022 06:12

Head branch was pushed to by a user without write access

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12635/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12635/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12635/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12635/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12635/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12635/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12635/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12635/merge#BCU1XR#0

@deltakosh deltakosh merged commit 73de9c7 into BabylonJS:master Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saaratrix @deltakosh