Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CheckIsReady in scene #12625

Merged
merged 15 commits into from Jun 1, 2022
Merged

Improve CheckIsReady in scene #12625

merged 15 commits into from Jun 1, 2022

Conversation

sebavan
Copy link
Member

@sebavan sebavan commented Jun 1, 2022

No description provided.

@sebavan sebavan changed the title Check is ready Improve CheckIsReady in scene Jun 1, 2022
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12625/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12625/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12625/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12625/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12625/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12625/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12625/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12625/merge#BCU1XR#0

@deltakosh deltakosh merged commit aee4945 into BabylonJS:master Jun 1, 2022
alvov-evo pushed a commit to alvov-evo/Babylon.js that referenced this pull request Jun 16, 2022
@sebavan @alvov-evo
Improve CheckIsReady in scene (BabylonJS#12625)
5e609c2 
* Fix prepass view uniform

* Format

* PBR refractionIntensityTexture in the inspector

* Fix registerInstancedBuffer after Mesh creation

* Fix Shadows after unparenting

* PR feedback

* Fix JPEG environment texture

* fix format

* No Delay to check readyness first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh approved these changes

Assignees
No one assigned
Labels
enhancement rendering engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sebavan @deltakosh