Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene.multiPickWithRay Typescript Defines are incorrect #12614

Closed
GimpMaster opened this issue May 31, 2022 · 3 comments · Fixed by #12621
Closed

Scene.multiPickWithRay Typescript Defines are incorrect #12614

GimpMaster opened this issue May 31, 2022 · 3 comments · Fixed by #12621
Assignees

Comments

@GimpMaster
Copy link

In the documentation for Scene.multiPickWithRay it says the following:

Predicate function used to determine eligible meshes. Can be set to null.

However the typescript interface shows:

multiPickWithRay(ray: Ray, predicate: (mesh: AbstractMesh) => boolean, trianglePredicate?: TrianglePickingPredicate): Nullable<PickingInfo>

requiring that a predicate is passed. I was able to // @ts-ignore this but that feels dirt.

Screenshots

image

@deltakosh
Copy link
Contributor

cc @RaananW

@RaananW RaananW self-assigned this Jun 1, 2022
alvov-evo pushed a commit to alvov-evo/Babylon.js that referenced this issue Jun 16, 2022
@wmurphyrd
Copy link
Contributor

Changelog says this was released in 5.9.0, but I still have the issue with scene.multiPickWithRay in 5.14.1.

Looks like this signature in scene.ts may also need to be updated https://github.com/BabylonJS/Babylon.js/blob/master/packages/dev/core/src/scene.ts#L4952

cc @RaananW

@RaananW
Copy link
Member

RaananW commented Aug 15, 2022

Changelog says this was released in 5.9.0, but I still have the issue with scene.multiPickWithRay in 5.14.1.

Looks like this signature in scene.ts may also need to be updated https://github.com/BabylonJS/Babylon.js/blob/master/packages/dev/core/src/scene.ts#L4952

cc @RaananW

Good catch. #12873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants