Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing observer trigger - onLoadedObservable notify method for hdrCubeTexture #12601

Merged
merged 1 commit into from May 30, 2022

Conversation

slash9494
Copy link
Contributor

I found a minor issue during loading textures through add task of asset manager
when I try to load the same texture files several times for different purposes, cubeTextureTask can be finished normally but hdrCubeTextureTask can't be finished even though it has been already finished

So, I have debugged and I found the creating function of hdrTexture has lost the load observable notify method that is included in the creating function of cubeTexture

  • engine.cubeTexture.ts

스크린샷 2022-05-30 오후 3 57 43

스크린샷 2022-05-30 오후 3 57 36

  • engine.rawTexture.ts

스크린샷 2022-05-30 오후 3 57 57

스크린샷 2022-05-30 오후 3 59 26

I add above code in raw texture and then it worked well
스크린샷 2022-05-30 오후 4 06 10

…eateRawCubeTextureFromUrl for hdrCubeTexture
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@sebavan sebavan merged commit 1f2b083 into BabylonJS:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants