Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a few methods to Quaternion and Vector3 #12598

Merged
merged 8 commits into from Jun 1, 2022

Conversation

BarthPaleologue
Copy link
Contributor

I noticed there was a few useful methods not implemented regarding transformations of Vector3 by Quaternions.

Here is what I added :

Quaternion

  • added subtractInPlace
  • added invertInPlace
  • added invert
  • added normalizeToNew
  • added lengthSquared

Vector3

  • added applyRotationQuaternionToRef
  • added applyRotationQuaternionInPlace
  • added applyRotationQuaternion

Other

  • Removed a few repetitions

- lengthSquared
- subtractInPlace
- normalizeToNew
- invert
- invertInPlace
- applyRotationQuaternionToRef
- applyRotationQuaternionInPlace
- applyRotationQuaternion
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@deltakosh
Copy link
Contributor

Good job!

@deltakosh deltakosh enabled auto-merge (squash) May 27, 2022 17:41
@azure-pipelines
Copy link

auto-merge was automatically disabled May 28, 2022 14:06

Head branch was pushed to by a user without write access

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@deltakosh deltakosh merged commit 2dbaeaa into BabylonJS:master Jun 1, 2022
alvov-evo pushed a commit to alvov-evo/Babylon.js that referenced this pull request Jun 16, 2022
* Update .gitignore

* Added methods to Quaternion

- lengthSquared
- subtractInPlace
- normalizeToNew

* Added methods to Quaternion

- invert
- invertInPlace

* added Quaternion transformations

- applyRotationQuaternionToRef
- applyRotationQuaternionInPlace
- applyRotationQuaternion

* aligning with braces conventions

* Prettier code

* added return annotations in tsdoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants