Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix render frame identification issue with instances #12597

Merged
merged 3 commits into from May 27, 2022
Merged

Fix render frame identification issue with instances #12597

merged 3 commits into from May 27, 2022

Conversation

deltakosh
Copy link
Contributor

No description provided.

@deltakosh deltakosh added the bug label May 27, 2022
@deltakosh deltakosh enabled auto-merge (squash) May 27, 2022 17:13
@deltakosh deltakosh requested a review from sebavan May 27, 2022 17:16
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/12597/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12597/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12597/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/12597/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/12597/merge
https://gui.babylonjs.com/?snapshot=refs/pull/12597/merge
https://nme.babylonjs.com/?snapshot=refs/pull/12597/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/12597/merge#BCU1XR#0

@deltakosh deltakosh disabled auto-merge May 27, 2022 18:20
@deltakosh deltakosh merged commit 49a6cee into master May 27, 2022
@deltakosh deltakosh deleted the fix-render-id branch May 27, 2022 18:20
alvov-evo pushed a commit to alvov-evo/Babylon.js that referenced this pull request Jun 16, 2022
@deltakosh @alvov-evo
Fix render frame identification issue with instances (BabylonJS#12597)
fffc71e 
* Fix render frame indentification issue with instances

* format

* better fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan Awaiting requested review from sebavan

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@deltakosh