Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove private variables from WebGPU declaration #12596

Merged
merged 1 commit into from May 27, 2022
Merged

remove private variables from WebGPU declaration #12596

merged 1 commit into from May 27, 2022

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented May 27, 2022

The reason behind this is the documentation page that fails compilation because of this error:

 Class 'GPUOutOfMemoryError' incorrectly implements class 'GPUError'. Did you mean to extend 'GPUError' and inherit its members as a subclass?
  Types have separate declarations of a private property '__brand'.
Error: C:/Users/raweber/Documents/GitHub/Documentation/.temp/docdirectory/doc.d.ts(97057)
 Class 'GPUValidationError' incorrectly implements class 'GPUError'. Did you mean to extend 'GPUError' and inherit its members as a subclass?
  Types have separate declarations of a private property '__brand'.

The reason for the error is probably an older version of typedoc (work is being done to update that), which uses an older version of typescript to analyze the file.

As this private variable is not being used anywhere in the code I took delibery of suggesting to remove it, but I will wait for @Popov72 to approve this PR before merging

@RaananW RaananW requested review from Popov72 and sebavan May 27, 2022 13:02
@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@deltakosh deltakosh merged commit 010a6c5 into BabylonJS:master May 27, 2022
@RaananW RaananW deleted the removePrivateFields branch May 27, 2022 23:38
@bghgary
Copy link
Contributor

bghgary commented May 28, 2022

Is there a workaround for this? Latest npm package 5.8.0 doesn't build because of this.

alvov-evo pushed a commit to alvov-evo/Babylon.js that referenced this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants