Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard around .note.GNU-stack sections in c/blake3_*_x86-64_unix.S is too restrictive #376

Open
rorth opened this issue Jan 24, 2024 · 0 comments

Comments

@rorth
Copy link

rorth commented Jan 24, 2024

As reported in [Support] Adjust .note.GNU-stack guard in Support/BLAKE3/blake3_*_x86… #76229 , links that include the c/blake3_*_x86-64_unix.o files on non-Linux ELF targets cause GNU ld warnings:

ld: warning: blake3_avx512_x86-64_unix.S.o: missing .note.GNU-stack section implies executable stack
ld: NOTE: This behaviour is deprecated and will be removed in a future version of the linker

The problem is that the files currently emit .note.GNU-stack sections on Linux only. However, clang emits them on every ELF target but Solaris.

The patch in that pull request (now committed) fixes this by adjusting the guard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant