Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How could I contribute BLAKE3's cmake file for community #320

Open
25077667 opened this issue Jun 28, 2023 · 3 comments
Open

How could I contribute BLAKE3's cmake file for community #320

25077667 opened this issue Jun 28, 2023 · 3 comments

Comments

@25077667
Copy link

25077667 commented Jun 28, 2023

Here is my cmake file.

Would you like to add it into your supply chain?
https://github.com/25077667/BLAKE3-cmake

Thanks.

@oconnor663
Copy link
Member

@BurningEnlightenment has been doing a lot of work on the CMake build files in this repo: https://github.com/BLAKE3-team/BLAKE3/blob/master/c/CMakeLists.txt. I think the best way to contribute would be to open a PR with any changes you think we should make to that file.

@BurningEnlightenment
Copy link
Collaborator

I think the best way to contribute would be to open a PR with any changes you think we should make to that file.

He doesn't propose changes to the/a new buildsystem, but has written a CMake script with FetchContent which downloads and builds BLAKE3 with the current CMake buildsystem as a dependency. FetchContent is sort of a poor man's package manager replacement.

We could add some example excerpts with FetchContent to #316, but we should guide our users to pin the downloaded source archive with a SHA-2 hash, don't invoke build commands manually but use FetchContent_MakeAvailable and SOURCE_SUBDIR.

Anyways, using a proper package manager like conan or vcpkg is strongly recommended.

@25077667
Copy link
Author

25077667 commented Jul 7, 2023

Hello @BurningEnlightenment , I apologize for the delayed response. I was quite busy last week.

Regarding your question, there are indeed other C++ package helpers available for managing third-party libraries. However, I would like to introduce you to an excellent package manager called CPM. You can find it at https://github.com/cpm-cmake/CPM.cmake. CPM is based on CMake and offers the advantage of being able to execute standalone. It's definitely worth exploring for your needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants