Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite CLI using Derive API #259

Merged
merged 3 commits into from Nov 20, 2022
Merged

Conversation

sorairolake
Copy link
Contributor

@sorairolake sorairolake commented Sep 14, 2022

This makes the code easier to read, write and modify.

ref: When should I use the builder vs derive APIs?

@oconnor663
Copy link
Member

Thank you, I've been meaning to do this for a while. Now that v4 is out, do you think it makes sense to go ahead and upgrade at the same time?

@sorairolake
Copy link
Contributor Author

Bump clap to v4.0.
Also, change to print the summary only, when short help (-h) is specified.

@oconnor663 oconnor663 merged commit 62bba46 into BLAKE3-team:master Nov 20, 2022
@oconnor663
Copy link
Member

Sorry for the delay in merging this, and thanks so much for saving me from reading through the clap v4 changelog 😅

@sorairolake sorairolake deleted the rewrite-cli branch November 22, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants