Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit time picker on mobile not working #265

Open
elodieburtin opened this issue May 10, 2020 · 3 comments
Open

Edit time picker on mobile not working #265

elodieburtin opened this issue May 10, 2020 · 3 comments
Labels
component/ui UI related issues priority/medium sev/bug Something isn't working

Comments

@elodieburtin
Copy link
Collaborator

When editing a form containing a time picker (e.g. event update/game update), the field is pre-filled with hh:mm:ss, which is invalid because seconds should not be specified.
@elodieburtin elodieburtin added sev/bug Something isn't working component/ui UI related issues priority/medium labels May 10, 2020
@hjwk
Copy link
Collaborator

hjwk commented May 21, 2020 •
edited

Is it not a glitch of the browser developer mode ? It does not happen on my phone and the timepicker is completely broken when emulating in a desktop browser (it shows --:-- -- and is unusable)

@elodieburtin
Copy link
Collaborator Author

No, it happens on waliens' phone and mine.

@hjwk
Copy link
Collaborator

hjwk commented Jul 13, 2020

Had it happen to me as well, looks like the magic start time suggestion unearthed this bug in the datetimepicker by providing it with HH::MM:SS data

hjwk added a commit to BGWE/BoardgameWE-UI that referenced this issue Jul 13, 2020
@hjwk
Tentative fix for BGWE/BoardgameWE#265
4bfbef9
hjwk added a commit to BGWE/BoardgameWE-UI that referenced this issue Aug 30, 2020
@hjwk
Merge pull request #63 from BGWE/fix_mobile_timepicker
089810b 
Tentative fix for BGWE/BoardgameWE#265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/ui UI related issues priority/medium sev/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hjwk @elodieburtin