Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos in telemetry #5531

Merged
merged 8 commits into from
Jan 5, 2023
Merged

Fix typos in telemetry #5531

merged 8 commits into from
Jan 5, 2023

Conversation

bmahall
Copy link
Contributor

@bmahall bmahall commented Jan 5, 2023

astsyAsyncMeasurement->atsAsyncMeasurement
startMeasuremeant->startMeasurement

@github-actions github-actions bot added msal-browser Related to msal-browser package msal-common Related to msal-common package labels Jan 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2023 •
edited

Codecov Report

Merging #5531 (5f37c36) into dev (4ed1f69) will not change coverage.
The diff coverage is 100.00%.

Flag Coverage Δ *Carryforward flag
msal-angular 96.50% <ø> (ø)
msal-common 85.22% <100.00%> (ø) Carriedforward from 4ed1f69
msal-core 82.84% <ø> (ø) Carriedforward from 4ed1f69
msal-node 83.37% <ø> (ø)
msal-node-extensions 76.03% <ø> (ø)
msal-react 94.68% <ø> (ø)
node-token-validation 88.88% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...mon/src/telemetry/performance/PerformanceClient.ts 93.96% <100.00%> (ø)
...src/telemetry/performance/StubPerformanceClient.ts 100.00% <100.00%> (ø)

@bmahall bmahall merged commit cae5e2f into dev Jan 5, 2023
@bmahall bmahall deleted the fix-typos-telemetry-dev branch January 5, 2023 21:08
@ghost
Copy link

ghost commented Jan 9, 2023

🎉@azure/msal-common@v9.0.2 has been released which incorporates this pull request.:tada:

We recommend upgrading to the latest version of @azure/msal-browser or @azure/msal-node to take advantage of this change.

Handy links:

@ghost
Copy link

ghost commented Jan 10, 2023

🎉@azure/msal-browser@v2.32.2 has been released which incorporates this pull request.:tada:

Handy links:

This was referenced Jan 17, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnorling tnorling tnorling approved these changes

@derisen derisen derisen approved these changes

@konstantin-msft konstantin-msft konstantin-msft approved these changes

@sameerag sameerag Awaiting requested review from sameerag sameerag is a code owner

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

@jo-arroyo jo-arroyo Awaiting requested review from jo-arroyo jo-arroyo is a code owner

@peterzenz peterzenz Awaiting requested review from peterzenz peterzenz is a code owner

@bgavrilMS bgavrilMS Awaiting requested review from bgavrilMS

@Robbie-Microsoft Robbie-Microsoft Awaiting requested review from Robbie-Microsoft Robbie-Microsoft is a code owner

Assignees
No one assigned
Labels
msal-browser Related to msal-browser package msal-common Related to msal-common package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bmahall @codecov-commenter @tnorling @derisen @konstantin-msft