Fix circular dependency #5402
Merged
Fix circular dependency #5402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnorling
requested review from
sameerag,
hectormmg,
bmahall,
peterzenz,
jennyf19,
jmprieur,
bgavrilMS and
Robbie-Microsoft
as code owners
Codecov Report
*This pull request uses carry forward flags. Click here to find out more.
|
derisen
approved these changes
Nov 17, 2022
sameerag
reviewed
Nov 21, 2022
| @@ -122,7 +122,7 @@ const DEFAULT_LOGGER_OPTIONS: LoggerOptions = { | |||
|
|
|||
| const DEFAULT_SYSTEM_OPTIONS: Required<NodeSystemOptions> = { | |||
| loggerOptions: DEFAULT_LOGGER_OPTIONS, | |||
| networkClient: NetworkUtils.getNetworkClient(), | |||
| networkClient: new HttpClient(), | |||
There was a problem hiding this comment.
I thought the initial idea was to ensure generic client setup, where setNetworkClient() would enable them to set the specific network client.
sameerag
approved these changes
Nov 21, 2022
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes circular dependency