msal-node serializes/deserializes userAssertionHash #5398
Merged
+15
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derisen
requested review from
sameerag,
tnorling,
hectormmg,
bmahall,
peterzenz,
jennyf19,
jmprieur,
bgavrilMS and
Robbie-Microsoft
as code owners
Codecov Report
*This pull request uses carry forward flags. Click here to find out more.
|
derisen
commented
Nov 16, 2022
| @@ -84,7 +84,8 @@ export class Serializer { | |||
| key_id: atEntity.keyId, | |||
| token_type: atEntity.tokenType, | |||
| requestedClaims: atEntity.requestedClaims, | |||
| requestedClaimsHash: atEntity.requestedClaimsHash | |||
| requestedClaimsHash: atEntity.requestedClaimsHash, | |||
| userAssertionHash: atEntity.userAssertionHash | |||
There was a problem hiding this comment.
Wasn't sure to follow camel or snake casing here (not sure why we switched). This method could possibly use a refactoring to not require manual mapping from AccessTokenEntity to SerializedAccessTokenEntity
bgavrilMS
approved these changes
Nov 21, 2022
|
LGTM |
Robbie-Microsoft
approved these changes
Nov 23, 2022
|
🎉 Handy links: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #5397
p.s. will update the obo sample separately for manual testing. will also check if MSIDLabs support OBO flow for E2E testing.