-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed MSAL-Node HttpClient AAD-Server-Error-500 Bug #5342
Conversation
Codecov Report
*This pull request uses carry forward flags. Click here to find out more.
|
change/@azure-msal-node-30bda6e0-6f74-44e0-981f-a7a155ef23ad.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments, mostly around code structure and readability.
@@ -12,8 +12,19 @@ export enum HttpMethod { | |||
} | |||
|
|||
export enum HttpStatus { | |||
OK = 200, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not being used anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one final comment to complete the status checks and error assignments. Approving though.
🎉 Handy links: |
Previous refactor of MSAL-Node's HttpClient was not tested with an actual 500 error from an AAD server. After using Fiddler Everywhere to further test HttpClient and simulate a 500 error from an AAD server, it was discovered that a 500 error returned from an AAD server would break the application. This PR covers additional functionality in HttpClient to address a 500 error returned from an AAD server.