Don't reassign request object properties #4563
Merged
+34
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnorling
requested review from
pkanher617,
jasonnutter and
peterzenz
as code owners
Codecov Report
*This pull request uses carry forward flags. Click here to find out more.
|
jasonnutter
approved these changes
Mar 1, 2022
hectormmg
approved these changes
Mar 3, 2022
bmahall
approved these changes
Mar 3, 2022
azure-pipelines bot
pushed a commit
that referenced
this pull request
Mar 3, 2022
* don't update request object * Change files * await all 3 promises
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initializeBaseRequestcurrently reassigns some properties of the original request causing issues with thumbprinting for concurrent requests. This PR fixes this behavior.