Skip to content

[Feature Request] Authority Validation enhacements #3775

Closed
@bgavrilMS

Description

@bgavrilMS
Member

This is a consistency item.

Spec is here: https://microsoft.sharepoint.com/:w:/t/ADAL/ESzbQvzlMuBDjAsqfaHdjNUBsTmwIUR5g17IAY4rvOY_Hw?e=7dv5hZ

Tasks

  • Implement phase 2 WithInstanceDiscoevryEndpoint("DISABLED") which turns off all instance discovery
    Ensure ESTS-R scenarios work in conjunction with this setting
    Testing

@rayluo to confirm that only phase 2 is required and if phase1 ("WithKnownAuthorityHosts") is optional / recommended etc.

Activity

added this to the 4.49.0 milestone on Oct 31, 2022
rayluo

rayluo commented on Oct 31, 2022

@rayluo
Contributor

@rayluo to confirm that only phase 2 is required and if phase1 ("WithKnownAuthorityHosts") is optional / recommended etc.

Yes. Also, that internal specs grew along with the lengthy conversation. If you just want to focus on what ended up happening, this implementation PR in MSAL Python shipped only a boolean instance_discovery=True or False. You can for example take a look into its unit test cases.

self-assigned this
on Nov 10, 2022
moved this from Triage to In Progress in MSAL Customer Truston Nov 10, 2022
moved this from In Progress to Waiting for Code Review in MSAL Customer Truston Nov 23, 2022
Repository owner moved this from Waiting for Code Review to Fixed in MSAL Customer Truston Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

Status

Done

Relationships

None yet

    Participants

    @rayluo@bgavrilMS@trwalke

    Issue actions

      [Feature Request] Authority Validation enhacements · Issue #3775 · AzureAD/microsoft-authentication-library-for-dotnet