Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] All validation delegates should be async and return a validation result #2568

Open
jmprieur opened this issue Apr 23, 2024 · 1 comment
Open

[Feature Request] All validation delegates should be async and return a validation result #2568

jmprieur opened this issue Apr 23, 2024 · 1 comment
Assignees
@brentschmaltz
Labels
sync-over-async

Comments

@jmprieur
Copy link
Contributor

jmprieur commented Apr 23, 2024 •
edited

Why?

  • We want to avoid the sync over async
  • We don't want to throw when there are several authentication schemes

What?

Add more delegates that are async and result a validation result

Size: XL in Wilson, SAL, MISE.

Open Issue:
RSA is not async ... we'll have to have async to sync,
@pmaytak
Copy link
Contributor

pmaytak commented Apr 23, 2024

Will fix #2556, #468

@pmaytak pmaytak mentioned this issue Apr 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brentschmaltz brentschmaltz

Labels
sync-over-async
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brentschmaltz @jmprieur @jennyf19 @pmaytak