Add SHA-2 self-signed cert and use SecureString as password parameter #1656
+106
−73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciaozhang
requested review from
GeoK,
brentschmaltz,
mafurman,
RojaEnnam and
SameerK-MSFT
ciaozhang
force-pushed
the
xiao/fixsecuritybugs
branch
from
c16c902 to
3dd0776
Compare
|
LGTM. I will leave it to someone in Wilson team to sign off. |
mafurman
approved these changes
Jun 24, 2021
RojaEnnam
reviewed
Jun 24, 2021
test/Microsoft.IdentityModel.Tokens.Tests/RsaCryptoServiceProviderProxyTests.cs
Show resolved
Hide resolved
GeoK
reviewed
Jun 24, 2021
| "_justification": "File contains tokens that are used only for testing purposes." | ||
| } | ||
| ] | ||
| "suppressions": [ |
GeoK
reviewed
Jun 24, 2021
| private static SecureString ConvertToSecureString(string password) | ||
| { | ||
| if (password == null) | ||
| throw new ArgumentNullException("password"); |
There was a problem hiding this comment.
nit: can be replaced with nameof(password)
GeoK
approved these changes
Jun 24, 2021
RojaEnnam
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix security bugs:
Using SHA256 and create a new self-signed cert
Using SecureString as password parameter