Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.4.5 was a breaking change for GitHub Self-Hosted Runner users #325

Closed
cperfect opened this issue May 26, 2023 · 2 comments
Closed

v1.4.5 was a breaking change for GitHub Self-Hosted Runner users #325

cperfect opened this issue May 26, 2023 · 2 comments
Assignees
Labels
need-to-triage Requires investigation

Comments

@cperfect
Copy link

cperfect commented May 26, 2023

We have just been hit by this issue docker/login-action#159 using this action via the version "v1" on Self Hosted runners: The v1.4.5 release includes the note "Also upgraded the Node version to 16.".

While we can upgrade our self hosted runners to fix this surely this is a breaking change and, assuming semantic versioning, this should require a major version increment?

@cperfect cperfect added the need-to-triage Requires investigation label May 26, 2023
@cperfect cperfect changed the title How does versioning work on this action? v1.4.5 was a breaking change for GitHub Self-Hosted Runner users May 26, 2023
@YanaXu YanaXu self-assigned this May 31, 2023
@YanaXu
Copy link
Collaborator

YanaXu commented May 31, 2023

Hi @cperfect
Thanks for bringing the message to us.
Can you provide the details of your problem? What happened after you upgraded the Azure Login Action version from v1 to v1.4.5? Do you mean you have to install new software or upgrade some software on your self-hosted runner?

@YanaXu
Copy link
Collaborator

YanaXu commented Sep 19, 2023

Hi @cperfect , I'm closing this issue since it's idle for a few months. Feel free to reopen it if necessary and please provide the information.

@YanaXu YanaXu closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-to-triage Requires investigation
Projects
None yet
Development

No branches or pull requests

2 participants