Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ManagedHSM endpoint and resource id #689

Merged
merged 1 commit into from Mar 30, 2022

Conversation

aramase
Copy link
Member

@aramase aramase commented Mar 30, 2022

ref: https://docs.microsoft.com/en-us/azure/key-vault/general/about-keys-secrets-certificates
ManagedHSM is only supported in AzurePublicCloud.

Signed-off-by: Anish Ramasekar anish.ramasekar@gmail.com

Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.

As part of submitting, please make sure you can make the following assertions:

  • I've tested my changes, adding unit tests if applicable.
  • I've added Apache 2.0 Headers to the top of any new source files.

ref: https://docs.microsoft.com/en-us/azure/key-vault/general/about-keys-secrets-certificates
ManagedHSM is only supported in AzurePublicCloud.

Signed-off-by: Anish Ramasekar <anish.ramasekar@gmail.com>
@jhendrixMSFT jhendrixMSFT merged commit 46c82ac into Azure:master Mar 30, 2022
@aramase aramase deleted the managed-hsm branch March 30, 2022 17:45
@aramase
Copy link
Member Author

aramase commented Mar 31, 2022

@jhendrixMSFT when is the next autorest release planned for?

@jhendrixMSFT
Copy link
Member

Should be by EOD. I have one other PR to merge first.

@jhendrixMSFT
Copy link
Member

Fixed in autorest@v0.11.25

@aramase
Copy link
Member Author

aramase commented Mar 31, 2022

Thanks, Joel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants