Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a default transport #654

Merged
merged 2 commits into from
Sep 10, 2021
Merged

Conversation

jhendrixMSFT
Copy link
Member

Type-asserting the http.DefaultTransport can fail if it was replaced
with a custom RoundTripper. Instead, create a new http.Transport with
the settings copied from http.DefaultTransport.

Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.

As part of submitting, please make sure you can make the following assertions:

  • I've tested my changes, adding unit tests if applicable.
  • I've added Apache 2.0 Headers to the top of any new source files.

Type-asserting the http.DefaultTransport can fail if it was replaced
with a custom RoundTripper.  Instead, create a new http.Transport with
the settings copied from http.DefaultTransport.
@jhendrixMSFT
Copy link
Member Author

Fixes #629

@jhendrixMSFT
Copy link
Member Author

We'll need to forward-port this to azcore.

Copy link
Member

@seankane-msft seankane-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

@jhendrixMSFT jhendrixMSFT merged commit 1417ae2 into Azure:master Sep 10, 2021
@jhendrixMSFT jhendrixMSFT deleted the default_transport branch September 10, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants