Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go versions (go1.15, go1.16, go1.17) #646

Merged
merged 1 commit into from
Aug 23, 2021
Merged

update go versions (go1.15, go1.16, go1.17) #646

merged 1 commit into from
Aug 23, 2021

Conversation

thaJeztah
Copy link
Contributor

see #645 (comment)

As part of submitting, please make sure you can make the following assertions:

  • I've tested my changes, adding unit tests if applicable.
  • I've added Apache 2.0 Headers to the top of any new source files.

@thaJeztah thaJeztah mentioned this pull request Aug 13, 2021
Merged
2 tasks
@thaJeztah
Copy link
Contributor Author

Hmm... probably outdated linter;

/home/vsts/work/_temp/dc578aa8-fc5c-4e34-bd4c-3fb0a4f9ff39.sh: line 1: golint: command not found
/home/vsts/work/_temp/dc578aa8-fc5c-4e34-bd4c-3fb0a4f9ff39.sh: line 2: golint: command not found

@thaJeztah thaJeztah force-pushed the update_go115 branch 2 times, most recently from eae873f to b539c02 Compare August 13, 2021 13:34
@thaJeztah
Copy link
Contributor Author

@jhendrixMSFT PTAL

jhendrixMSFT
jhendrixMSFT requested changes Aug 16, 2021
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI changes are good but we can't take the go.mod changes.

autorest/adal/go.mod Show resolved Hide resolved
@thaJeztah thaJeztah changed the title update to currently supported go versions (go1.15, go1.16) update go versions (go1.15, go1.16, go1.17) Aug 23, 2021
@thaJeztah
update go versions (go1.15, go1.16, go1.17)
e312251 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Contributor Author

Ah, cool, my condition: worked (thanks StackOverflow 😂), and it's green again 👍

@jhendrixMSFT jhendrixMSFT merged commit 34360dd into Azure:master Aug 23, 2021
@jhendrixMSFT
Copy link
Member

I will work on releasing the updated modules a bit later today.

@thaJeztah thaJeztah deleted the update_go115 branch August 23, 2021 18:32
@thaJeztah
Copy link
Contributor Author

Let me rebase my other PR now that this one's merged

Nirusu pushed a commit to Nirusu/go-autorest that referenced this pull request Aug 23, 2021
@thaJeztah @Nirusu
update go versions (go1.15, go1.16, go1.17) (Azure#646)
10ed731 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@thaJeztah @jhendrixMSFT