Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more parameters to get-access-token #643

Merged
merged 8 commits into from
Aug 25, 2021
Merged

Add more parameters to get-access-token #643

merged 8 commits into from
Aug 25, 2021

Conversation

fondoger
Copy link
Contributor

@fondoger fondoger commented Aug 4, 2021

Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.

As part of submitting, please make sure you can make the following assertions:

  • I've tested my changes, adding unit tests if applicable.
  • I've added Apache 2.0 Headers to the top of any new source files.

jhendrixMSFT
jhendrixMSFT requested changes Aug 23, 2021
View reviewed changes
Copy link
Member

@jhendrixMSFT jhendrixMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. A few things to tweak before this can be merged.

autorest/azure/cli/token.go Outdated Show resolved Hide resolved
autorest/azure/cli/token.go Outdated Show resolved Hide resolved
@jhendrixMSFT
Copy link
Member

Fixes #632

@fondoger fondoger closed this Aug 24, 2021
@fondoger fondoger reopened this Aug 24, 2021
@jhendrixMSFT jhendrixMSFT merged commit cf74520 into Azure:master Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fondoger @jhendrixMSFT