Print error to info log before backing off #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhendrixMSFT
approved these changes
Aug 23, 2021
Nirusu
force-pushed
the
log-before-backoff
branch
2 times, most recently
from
10ed731
to
83f7a08
Compare
|
@Nirusu also, can you please sign the CLA? There's a link above. |
|
Sorry for the force-pushes, actually changed the "sleeping for" message by accident too; removed that change. Yup, no problem, signed the CLA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.
As part of submitting, please make sure you can make the following assertions:
This is a small change I made that should help users of the Azure SDK debugging networking issues whenever DelayForBackoff(WithCap) is called. Normally you will have to wait until the cap is reached to actually see the error. With this change, it should be printed to the info log (assuming
AZURE_GO_SDK_LOG_LEVELis set at least toInfo) before DelayForBackoff(WithCap) is called, so that potential errors can be detected quicker.