Changing default polling interval from 60 to 30 #621
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposing this change following email discussion on making it less conservative. What do you think of this change? Now it makes me think, can we update the `DefaultRetryDuration` from 30 seconds to 15 seconds if the change above is fine?
jhendrixMSFT
reviewed
Mar 8, 2021
| @@ -31,7 +31,7 @@ import ( | |||
|
|
|||
| const ( | |||
| // DefaultPollingDelay is a reasonable delay between polling requests. | |||
| DefaultPollingDelay = 60 * time.Second | |||
| DefaultPollingDelay = 30 * time.Second | |||
There was a problem hiding this comment.
This could end up doubling the number of GET calls during polling which might impact large-scale apps and introduce throttling. This needs to be investigated before we could merge this as it affects everybody.
|
Closing for now. If we get data that confirms we can safely make this change please ping back. |
jhendrixMSFT
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposing this change following email discussion on making it less conservative. What do you think of this change?
Now it makes me think, can we update the
DefaultRetryDurationfrom 30 seconds to 15 seconds if the change above is fine?Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.
As part of submitting, please make sure you can make the following assertions: