Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return an error if resp and err are nil #618

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Return an error if resp and err are nil #618

merged 1 commit into from
Feb 10, 2021

Conversation

jhendrixMSFT
Copy link
Member

Thank you for your contribution to Go-AutoRest! We will triage and review it as soon as we can.

As part of submitting, please make sure you can make the following assertions:

  • I've tested my changes, adding unit tests if applicable.
  • I've added Apache 2.0 Headers to the top of any new source files.

@jhendrixMSFT jhendrixMSFT changed the title Return an error is resp and err are nil Return an error if resp and err are nil Feb 10, 2021
catalinaperalta
catalinaperalta approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhendrixMSFT jhendrixMSFT merged commit c7f947c into Azure:master Feb 10, 2021
@jhendrixMSFT jhendrixMSFT deleted the autorest_resp branch February 10, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catalinaperalta catalinaperalta catalinaperalta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jhendrixMSFT @catalinaperalta