Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to tokio 1.0 #60

Closed
3 tasks done
ctaggart opened this issue Oct 22, 2020 · 6 comments · Fixed by #144
Closed
3 tasks done

upgrade to tokio 1.0 #60

ctaggart opened this issue Oct 22, 2020 · 6 comments · Fixed by #144
Assignees

Comments

@ctaggart
Copy link
Contributor

ctaggart commented Oct 22, 2020

This requires other dependencies to upgrade first:

@ctaggart
Copy link
Contributor Author

ctaggart commented Jan 5, 2021

reqwest just released with support for tokio 1.0 https://github.com/seanmonstar/reqwest/releases/tag/v0.11.0

@ctaggart ctaggart changed the title upgrade to tokio 0.3 upgrade to tokio 1.0 Jan 5, 2021
@ctaggart
Copy link
Contributor Author

ctaggart commented Jan 5, 2021

It builds on top of top of hyper 0.14 which came out a couple of weeks ago. https://github.com/hyperium/hyper/releases

@rylev
Copy link
Contributor

rylev commented Jan 6, 2021

This is fixed in the SDK crates with #136 and needs to only be updated in the services crates now.

@karataliu
Copy link
Contributor

Seems I cannot use storage controlplane(mgmt) SDK(tokio 0.2) dataplane(tokio 1.0) in same function now:

When runtime is 1.0:

panicked at 'not currently running on the Tokio runtime.', \.cargo\registry\src\github.com-1ecc6299db9ec823\tokio-1.0.1\src\runtime\blocking\pool.rs:84:33

When runtime is 0.2, it will complain from 0.2 code.

@ctaggart
Copy link
Contributor Author

@karataliu, apologies. Working on the upgrade.

@ctaggart ctaggart self-assigned this Jan 12, 2021
@ctaggart
Copy link
Contributor Author

I'm just waiting on #143 to be merged first. The fix in just updating these dependencies:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants