Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make ImdsManagedIdentityCredential public again #1660

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

make ImdsManagedIdentityCredential public again #1660

wants to merge 1 commit into from

Conversation

cataggar
Copy link
Member

@cataggar cataggar commented May 14, 2024 •
edited

Fixes #1659. As it points out, I think it was a bit too early to make ImdsManagedIdentityCredential private in #1532. I think it is the right direction after the credentials that use it like VirtualMachineManagedIdentityCredential and AppServiceManagedIdentityCredential add support for configurating user managed identities.

@cataggar cataggar mentioned this pull request May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths heaths approved these changes

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@JeffreyRichter JeffreyRichter Awaiting requested review from JeffreyRichter JeffreyRichter is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use a User Assigned Managed Identity with azure_identity 0.20.0
2 participants
@cataggar @heaths