Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tox-monorepo for tox 4.0, update CI to consume tox 4.0 #28267

Closed
2 tasks
scbedd opened this issue Jan 10, 2023 · 2 comments · Fixed by #30159
Closed
2 tasks

Update tox-monorepo for tox 4.0, update CI to consume tox 4.0 #28267

scbedd opened this issue Jan 10, 2023 · 2 comments · Fixed by #30159
Assignees
@kdestin
Labels
EngSys This issue is impacting the engineering system.

Comments

@scbedd
Copy link
Member

scbedd commented Jan 10, 2023 •
edited

Tox 4.0 is a fairly massive shift in internals even if the migration guide doesn't seem too bad.

We shipped tox-monorepo for tox<4. This enables us to re-use the same tox.ini file regardless of where we're starting from. You just need to provide the relative path to the tox.ini we use.

This issue covers support for tox>=4, and all the changes that are necessary to enable that.

  • git+https installs need to shift to new method instead of old egg method.
  • Any transitive dependencies that need to be updated due to the tox update.
@scbedd scbedd self-assigned this Jan 10, 2023
@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Jan 10, 2023
@github-actions github-actions bot added needs-triage This is a new issue that needs to be triaged to the appropriate team. and removed needs-triage This is a new issue that needs to be triaged to the appropriate team. labels Jan 10, 2023
@scbedd scbedd mentioned this issue Jan 24, 2023
Merged
@scbedd scbedd added EngSys This issue is impacting the engineering system. and removed Central-EngSys This issue is owned by the Engineering System team. labels Mar 15, 2023
@scbedd scbedd removed their assignment May 10, 2023
@kdestin kdestin mentioned this issue May 24, 2023
Merged
6 tasks
@kdestin
Copy link
Member

kdestin commented May 24, 2023

Resolved by #30159

@kdestin kdestin closed this as completed May 24, 2023
@scbedd
Copy link
Member Author

scbedd commented May 24, 2023

@kdestin I assigned you so your name is associated with the issue too. Great work!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kdestin kdestin

Labels
EngSys This issue is impacting the engineering system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[engsys] Migrate to tox4 kdestin/azure-sdk-for-python
2 participants
@scbedd @kdestin