Storage devtool migration #17396
Storage devtool migration #17396
Conversation
ghost
added
the
|
/azp run python - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xiafu-msft
requested review from
amishra-dev,
annatisch,
danieljurek,
kasobol-msft and
zezha-msft
as code owners
|
|
||
| class StorageTestCase(AzureTestCase): |
There was a problem hiding this comment.
I assume we're not inheriting from AzureMgmtTestcase because its deprecated? or what is the reason we're opting for AzureTestcase over AzureMgmtTestcase?
There was a problem hiding this comment.
StorageTestCase and AzureMgmtTestcase are both inheriting AzureTestcase. We don't need anything specific from either StorageTestCase/AzureMgmtTestcase, so there's no need to use them.
For example people who are using AzureMgmtTestcase is mainly because they need to create_mgmt_client to do some mgmt plane operation. For StorageTestCase we were using that to create storage account, while for datalake the storage account is created through ARM Template deployment so we don't need StorageTestCase either.
I know blob is using AzureMgmtTestcase probably when it was added we were using something?
There was a problem hiding this comment.
Ah ok that explains it - so blobs we have
when we're creating the account, whereas in Datalake we're directly passing account name and key using the ARM template to deploy these resources (storage accounts)?| # fixture needs to be visible from conftest | ||
|
|
||
| # Ignore async tests for Python < 3.5 | ||
| collect_ignore_glob = [] |
There was a problem hiding this comment.
Out of curiosity, how did we specify this prior to this migration?
There was a problem hiding this comment.
good question we specified here https://github.com/Azure/azure-sdk-for-python/blob/638969c03e19894ad23bbfc545783d71e777f540/sdk/storage/azure-storage-file-datalake/conftest.py
let me see how I can modify this
| @@ -5,6 +5,8 @@ | |||
| # license information. | |||
| # -------------------------------------------------------------------------- | |||
| from __future__ import division | |||
|
|
|||
| import functools | |||
There was a problem hiding this comment.
There's a bunch of imports that we can remove now that we're migrating
xiafu-msft
force-pushed
the
storage-devtool-migration
branch
from
1924ca5 to
ebd4b7e
Compare
No description provided.