Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Azure Maps] Search fixes #31753

Merged
merged 10 commits into from
Oct 13, 2022
Merged

[Azure Maps] Search fixes #31753

merged 10 commits into from
Oct 13, 2022

Conversation

dubiety
Copy link
Member

@dubiety dubiety commented Oct 12, 2022

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@dubiety
Copy link
Member Author

dubiety commented Oct 12, 2022

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

azure-sdk commented Oct 12, 2022

API change check

APIView has identified API level changes in this PR and created following API reviews.

Azure.Maps.Search
Azure.Maps.Rendering
Azure.Maps.Routing

@dubiety
Copy link
Member Author

dubiety commented Oct 12, 2022

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dubiety dubiety changed the title Feature/maps seach fix [Azure Maps] Search fixes Oct 12, 2022
@alextts627
Copy link
Contributor

/azp run net - maps - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dubiety
Copy link
Member Author

dubiety commented Oct 13, 2022

/azp run net - maps - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dubiety
Copy link
Member Author

dubiety commented Oct 13, 2022

/azp run net - maps - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dubiety
Copy link
Member Author

dubiety commented Oct 13, 2022

/azp run net - maps - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dubiety dubiety merged commit 5b13d2e into Azure:main Oct 13, 2022
@dubiety dubiety deleted the feature/maps-seach-fix branch October 13, 2022 14:42
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
* Update RenderingLanguage comment typo

* Add SearchLanguage, move part of the code to root namespace

* Use new LRO pattern

* Add more samples, simplify docstring and update APIs

* Update changelog

* Change `EnglishUSA` to `EnglishUsa`

* Add some sleep in wait for completion for Search LRO API test

* Update test cases

* Update possible API timing issues

* Update auth key location from query to header for Maps SDKs

Co-authored-by: Charlie Chen <charlie.chen@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants