Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overloads to TableTransaction.updateEntity #23132

Merged
6 commits merged into from Sep 7, 2022

Conversation

dgetu
Copy link
Member

@dgetu dgetu commented Sep 7, 2022

The existing API for TableTransaction.updateEntity requires passing undefined explicitly when using the default updateMode with updateOptions. This change allows for either optional argument to be passed through their respective binary function declaration.

@ghost ghost added the Tables label Sep 7, 2022
@dgetu dgetu marked this pull request as ready for review September 7, 2022 17:44
Copy link

@mane-dev mane-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Member

@joheredi joheredi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: :shipit:

@ghost
Copy link

ghost commented Sep 7, 2022

Hello @joheredi!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@joheredi joheredi added APIChange This PR contains an addition or change to the API signature and must be reviewed by an architect. and removed APIChange This PR contains an addition or change to the API signature and must be reviewed by an architect. labels Sep 7, 2022
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-data-tables

@ghost ghost merged commit 3adb516 into Azure:main Sep 7, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants