device update release #19728

dw511214992 · 2022-01-07T04:11:27Z

The PR conflict will be resloved in merging.

There is a manual change of generated codes in the PR. I have created an issue to track it in codegen: Azure/autorest.typescript#1284

sdk/deviceupdate/iot-device-update-rest/package.json

sdk/deviceupdate/iot-device-update-rest/test/public/utils/env.ts

sdk/deviceupdate/iot-device-update-rest/test/public/groupAndDeployment.spec.ts

check-enforcer · 2022-01-11T02:42:30Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

dw511214992 · 2022-01-17T01:42:57Z

/check-enforcer evaluate

xirzec

A few minor remarks, but I think I can approve once those are addressed. 👍

sdk/deviceupdate/iot-device-update-rest/README.md

sdk/deviceupdate/iot-device-update-rest/package.json

sdk/deviceupdate/iot-device-update-rest/review/iot-device-update.api.md

sdk/deviceupdate/iot-device-update-rest/sample.env

sdk/deviceupdate/iot-device-update-rest/test/public/utils/env.ts

dw511214992 · 2022-01-20T03:33:45Z

Changes look good. Please update the recorder to use the new recorder tool and we should be good.

@joheredi The latest PR has migrated to new recorder tool.

# Conflicts: # common/config/rush/pnpm-lock.yaml # eng/ignore-links.txt

dw511214992 · 2022-01-20T11:57:18Z

/azp run

azure-pipelines · 2022-01-20T11:57:23Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

dw511214992 · 2022-01-20T12:03:39Z

/azp run js - deviceupdate - ci, js - core - ci

azure-pipelines · 2022-01-20T12:04:09Z

Azure Pipelines successfully started running 2 pipeline(s).

dw511214992 · 2022-01-20T12:08:52Z

/azp run js - core - ci

azure-pipelines · 2022-01-20T12:09:11Z

Azure Pipelines successfully started running 1 pipeline(s).

xirzec

I feel good about the fixes to the API surface, just one last comment about the ignores.

eng/ignore-links.txt

joheredi

Looks great! Would you mind filing an issue to remove the ignore entries you added?

Thanks for taking the time to migrate to the new recorder /cc: @HarshaNalluru @timovv

HarshaNalluru · 2022-01-21T00:12:13Z

sdk/deviceupdate/iot-device-update-rest/test/public/utils/recordedClient.ts

+export function createRecordedClient(recorder: Recorder): DeviceUpdateRestClient {
+  const credential = createTestCredential();
+  const client = DeviceUpdate(assertEnvironmentVariable("ENDPOINT"), credential);
+  recorder.configureClient(client);


BTW, the tests look great with the new recorder, I really appreciate the work here. 🔥

However, recorder.configureClient(client); call is likely going to change based on the discussion at #16876 with the Arch board.

Basically, we don't want to expose "pipeline" object on the clients, which this client is currently doing.
We're instead going to go with an approach of adding policies in an array in the client options.
Change being made here - #19920

@xirzec this client exposes "pipeline", we don't want that, right?

@HarshaNalluru I think we don't need to use adding polices in this PR as the #19920 is not merged. If it's ready to use policies and you need my help, please let me know. For now, I will merge this PR to release the sdk. thanks

My comment was about the already exposed "pipeline" object on the client. 🙂
Many clients exposed it unintentionally, we're going to make a call for those - mostly making it private or something similar.
And this #19920 is to provide an alternative to allow adding policies.

Since there are other clients that are in a similar state as iot-device-update, we'll handle this package along with them if we ever decide to change something even if it is a breaking change.

dw511214992 · 2022-01-21T01:50:47Z

Looks great! Would you mind filing an issue to remove the ignore entries you added?

Thanks for taking the time to migrate to the new recorder /cc: @HarshaNalluru @timovv

ignore links are removed

Sync x-mx-enum change from 2021-03-01 (Azure#19728) * Sync x-mx-enum change from 2021-03-01 * Update Provider.json

device update release

db038e2

dw511214992 requested review from benbp, bterlson, deyaaeldeen, jeremymeng, mikeharder, praveenkuttappan, ramya-rao-a, witemple-msft and xirzec as code owners January 7, 2022 04:11

dw511214992 marked this pull request as draft January 7, 2022 04:11

dw511214992 added 3 commits January 7, 2022 12:45

ignore link

c965d4d

lint fix

01a4be0

format

0166aa6

dw511214992 marked this pull request as ready for review January 7, 2022 05:53

dw511214992 requested a review from weshaggard as a code owner January 7, 2022 05:53

xirzec reviewed Jan 10, 2022

View reviewed changes

sdk/deviceupdate/iot-device-update-rest/package.json Outdated Show resolved Hide resolved

xirzec reviewed Jan 10, 2022

View reviewed changes

sdk/deviceupdate/iot-device-update-rest/test/public/utils/env.ts Outdated Show resolved Hide resolved

xirzec reviewed Jan 10, 2022

View reviewed changes

sdk/deviceupdate/iot-device-update-rest/test/public/groupAndDeployment.spec.ts Outdated Show resolved Hide resolved

fix by comment

5997117

dw511214992 and others added 3 commits January 14, 2022 10:39

Merge branch 'main' into dw/deviceupdate

614db51

regenerate with latest swagger

d728b1a

revert

4c353b6

dw511214992 added 2 commits January 18, 2022 21:49

Merge branch 'main' into dw/deviceupdate

6d04e15

rush update

d536fd9

xirzec reviewed Jan 19, 2022

View reviewed changes

fix

1481e51

ramya-rao-a requested a review from joheredi January 19, 2022 06:14

dw511214992 added 2 commits January 20, 2022 08:40

revert

d044260

add ignore links

9c44b4a

dw511214992 added 11 commits January 20, 2022 11:35

manual change

90567c1

Merge branch 'main' into dw/deviceupdate

ab6c9f1

# Conflicts: # common/config/rush/pnpm-lock.yaml # eng/ignore-links.txt

rush update

0a848c2

update test recording

8e64d94

merge

cecca53

new test recorder

d289d9f

lint

5206706

fix

0fd2498

re-record

e1b6d9c

merge

b64cd15

rush update

7242f00

xirzec approved these changes Jan 20, 2022

View reviewed changes

eng/ignore-links.txt Outdated Show resolved Hide resolved

del ignore link

a0c6987

joheredi reviewed Jan 20, 2022

View reviewed changes

eng/ignore-links.txt Outdated Show resolved Hide resolved

joheredi approved these changes Jan 20, 2022

View reviewed changes

HarshaNalluru reviewed Jan 21, 2022

View reviewed changes

fix url

ed2c765

dw511214992 merged commit a95bf28 into main Jan 21, 2022

dw511214992 deleted the dw/deviceupdate branch January 21, 2022 02:14

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Jul 12, 2022

CodeGen from PR 19728 in Azure/azure-rest-api-specs

a53a33f

Sync x-mx-enum change from 2021-03-01 (Azure#19728) * Sync x-mx-enum change from 2021-03-01 * Update Provider.json

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

device update release #19728

device update release #19728

dw511214992 commented Jan 7, 2022 •

edited

check-enforcer bot commented Jan 11, 2022

dw511214992 commented Jan 17, 2022

xirzec left a comment

dw511214992 commented Jan 20, 2022 •

edited

dw511214992 commented Jan 20, 2022

azure-pipelines bot commented Jan 20, 2022

dw511214992 commented Jan 20, 2022

azure-pipelines bot commented Jan 20, 2022

dw511214992 commented Jan 20, 2022

azure-pipelines bot commented Jan 20, 2022

xirzec left a comment

joheredi left a comment

HarshaNalluru Jan 21, 2022 •

edited

HarshaNalluru Jan 21, 2022

dw511214992 Jan 21, 2022 •

edited

HarshaNalluru Jan 21, 2022

dw511214992 commented Jan 21, 2022

device update release #19728

device update release #19728

Conversation

dw511214992 commented Jan 7, 2022 • edited

check-enforcer bot commented Jan 11, 2022

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

dw511214992 commented Jan 17, 2022

xirzec left a comment

Choose a reason for hiding this comment

dw511214992 commented Jan 20, 2022 • edited

dw511214992 commented Jan 20, 2022

azure-pipelines bot commented Jan 20, 2022

dw511214992 commented Jan 20, 2022

azure-pipelines bot commented Jan 20, 2022

dw511214992 commented Jan 20, 2022

azure-pipelines bot commented Jan 20, 2022

xirzec left a comment

Choose a reason for hiding this comment

joheredi left a comment

Choose a reason for hiding this comment

HarshaNalluru Jan 21, 2022 • edited

Choose a reason for hiding this comment

HarshaNalluru Jan 21, 2022

Choose a reason for hiding this comment

dw511214992 Jan 21, 2022 • edited

Choose a reason for hiding this comment

HarshaNalluru Jan 21, 2022

Choose a reason for hiding this comment

dw511214992 commented Jan 21, 2022

dw511214992 commented Jan 7, 2022 •

edited

dw511214992 commented Jan 20, 2022 •

edited

HarshaNalluru Jan 21, 2022 •

edited

dw511214992 Jan 21, 2022 •

edited