Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Recorder] After mocha@7.0 update, skipping the test fails with an error #10664

Closed
HarshaNalluru opened this issue Aug 17, 2020 · 3 comments
Closed

[Recorder] After mocha@7.0 update, skipping the test fails with an error #10664

HarshaNalluru opened this issue Aug 17, 2020 · 3 comments
Assignees
@HarshaNalluru
Labels
Client This issue points to a problem in the data-plane of the library. test-utils-recorder Label for the issues related to the common recorder
Milestone
[2022] May

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Aug 17, 2020 •
edited

sync skip; aborting execution error is thrown when a test is skipped programmatically!

That breaks things for .skip() method exposed from the recorder.

TODO: Swallow the error thrown by mocha, and report the test to be pending.

Related
https://github.com/mochajs/mocha/blob/master/CHANGELOG.md#700--2020-01-05
mochajs/mocha#4030
mochajs/mocha#4083

/cc @nguerrera (Thanks for reporting)
@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Aug 17, 2020
@HarshaNalluru
Copy link
Member Author

More info:
Upon investigation, it appears to be that the failure happens only when the test is skipped in a nested describe block!!
To repro: b0955ca

@nguerrera nguerrera mentioned this issue Aug 18, 2020
Merged
@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. test-utils-recorder Label for the issues related to the common recorder labels Aug 18, 2020
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Aug 18, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] September milestone Aug 18, 2020
@nguerrera
Copy link
Contributor

SchemaRegistry is not blocked on this one, I've removed the nested describes.

@ramya-rao-a ramya-rao-a modified the milestones: [2020] November, MQ-2020 Dec 2, 2020
@ramya-rao-a ramya-rao-a modified the milestones: MQ-2020, Backlog Dec 22, 2020
@HarshaNalluru HarshaNalluru modified the milestones: Backlog, [2022] May Apr 5, 2022
@HarshaNalluru
Copy link
Member Author

Closing this since it is not relevant to recorder v2

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HarshaNalluru HarshaNalluru

Labels
Client This issue points to a problem in the data-plane of the library. test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Milestone
[2022] May
Development

No branches or pull requests
3 participants
@nguerrera @HarshaNalluru @ramya-rao-a