Make azure.ParamNotSpecifiedError unexported #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. |
This necessitates duplication of the error message across the various different packages, however for the cleanliness of the API this seems worthwhile given that the error messages should likely not be localized anyway.
jen20
force-pushed
the
private-error-messages
branch
from
c2a266c
to
f833f04
Compare
|
@jen20 Can you sign a CLA here: https://cla.msopentech.com/ ? |
|
@jen20 Sorry, we're switching to a new system, try: https://cla2.msopentech.com/ |
|
@jeffmendoza I just did a second one yesterday? |
|
Just done yet another CLA! |
ruslangabitov
added a commit
that referenced
this pull request
Feb 3, 2015
Make azure.ParamNotSpecifiedError unexported
marstr
pushed a commit
to marstr/azure-sdk-for-go
that referenced
this pull request
Apr 27, 2017
* Different funcs for write and clear blob pages * Fixed tests, and changed a name for consistency
marstr
pushed a commit
that referenced
this pull request
Apr 28, 2017
* Different funcs for write and clear blob pages * Fixed tests, and changed a name for consistency
mcardosos
added a commit
that referenced
this pull request
May 4, 2017
* Different funcs for write and clear blob pages * Fixed tests, and changed a name for consistency
AutorestCI
added a commit
that referenced
this pull request
May 24, 2019
Merge pull request #28 from leonardbf/NFSAAS-2436-R4-corrections NFSAAS-2436 corrections to R4 standard
AutorestCI
added a commit
that referenced
this pull request
Jun 4, 2019
… swagger for GA (#4861) * Generated from 3c2d64eec013f8a6a4666a83a2e3daf9fd44b821 Merge pull request #25 from leonardbf/NFSAAS-2436-R4-corrections NFSAAS-2436 corrections to R4 standard * Generated from f897f2476e09958144c8dd8f3db8699ee6636763 Merge pull request #26 from leonardbf/NFSAAS-2436-R4-corrections NFSAAS-2436 corrections to R4 standard * Generated from 81ff9dd1f123face9e3dae304a8971234c6a5542 Merge pull request #28 from leonardbf/NFSAAS-2436-R4-corrections NFSAAS-2436 corrections to R4 standard
jhendrixMSFT
pushed a commit
that referenced
this pull request
Jun 4, 2019
… swagger for GA (#4861) * Generated from 3c2d64eec013f8a6a4666a83a2e3daf9fd44b821 Merge pull request #25 from leonardbf/NFSAAS-2436-R4-corrections NFSAAS-2436 corrections to R4 standard * Generated from f897f2476e09958144c8dd8f3db8699ee6636763 Merge pull request #26 from leonardbf/NFSAAS-2436-R4-corrections NFSAAS-2436 corrections to R4 standard * Generated from 81ff9dd1f123face9e3dae304a8971234c6a5542 Merge pull request #28 from leonardbf/NFSAAS-2436-R4-corrections NFSAAS-2436 corrections to R4 standard
richardpark-msft
pushed a commit
to richardpark-msft/azure-sdk-for-go
that referenced
this pull request
Aug 5, 2021
Stripping away context from NewQueue constructor
richardpark-msft
pushed a commit
to richardpark-msft/azure-sdk-for-go
that referenced
this pull request
Aug 5, 2021
* Removing context from Subscription and Topic constructors. This is done to drive API consistency after Azure#28. The reasoning is the same; now that there is no out-of-process work to do in these constructors, there need not be a cancellation token injected. It would also make for some very verbose log messages. * Updating tests
benbp
pushed a commit
to benbp/azure-sdk-for-go
that referenced
this pull request
Sep 15, 2021
* Removing context from Subscription and Topic constructors. This is done to drive API consistency after Azure#28. The reasoning is the same; now that there is no out-of-process work to do in these constructors, there need not be a cancellation token injected. It would also make for some very verbose log messages. * Updating tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed during #26.
This necessitates duplication of the error message across the various different packages, however for the cleanliness of the API this seems worthwhile given that the error messages should likely not be localized anyway.