armconsumption.ModernReservationRecommendationProperties missing documented ResourceType field

[joshk0]

The armconsumption package currently uses api version 2021-10-01. However, according to docs, version 2023-05-01 is available, and has several added fields that are valuable to me.

Could armconsumption get regenerated with this new API version?

More generally speaking, is there a methodology for using different released API versions with the Go client?

[Alancere]

Hi @joshk0 thanks for this issue!

Releasing a new package will require the service to submit a new SDK release request, I have added the label on this issue so that the corresponding service team could take this a look.
I also sent some internal emails to the contact of the corresponding service team about this.

[github-actions]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @ArcturusZhang @lirenhe @tadelesh.

[Alancere]

Hi @joshk0, you could use different API versions through ClientOptions.APIVersion

[joshk0]

I've taken advantage of that for another API. But if the response structure is different, there's no way to override that; or is there?

[Alancere]

I've taken advantage of that for another API. But if the response structure is different, there's no way to override that; or is there?

I compared api version 2021-10-01 and 2023-11-01 and the definition of response is the same.

You could also configure the environment variable AZURE_SDK_GO_LOGGING=all to determine whether the specified api version is being used

[github-actions]

Hi @joshk0. Thank you for opening this issue and giving us the opportunity to assist. To help our team better understand your issue and the details of your scenario please provide a response to the question asked above or the information requested above. This will help us more accurately address your issue.

[github-actions]

Hi @joshk0, we're sending this friendly reminder because we haven't heard back from you in 7 days. We need more information about this issue to help address it. Please be sure to give us your input. If we don't hear back from you within 14 days of this comment the issue will be automatically closed. Thank you!

[joshk0]

I compared api version 2021-10-01 and 2023-11-01 and the definition of response is the same.

So I think you're right that it's the same spec wise, but the real problem is that there's a missing field in the Go SDK compared to this JSON spec.

It's several layers deep, but it's ModernReservationRecommendationProperties that's the difference. I am looking for the resourceType field within that; you can see it here in the public doc as well.

The field is present in the swagger definition of both 2021-10-01 and 2023-11-01, but it is not present within the Go SDK. Only the "Legacy" version of the Properties has it.

Why is this field missing from the Go SDK despite being on the public doc as well as the swagger spec that you build this from?

[Alancere]

I compared api version 2021-10-01 and 2023-11-01 and the definition of response is the same.

So I think you're right that it's the same spec wise, but the real problem is that there's a missing field in the Go SDK compared to this JSON spec.

It's several layers deep, but it's ModernReservationRecommendationProperties that's the difference. I am looking for the resourceType field within that; you can see it here in the public doc as well.

The field is present in the swagger definition of both 2021-10-01 and 2023-11-01, but it is not present within the Go SDK. Only the "Legacy" version of the Properties has it.

Why is this field missing from the Go SDK despite being on the public doc as well as the swagger spec that you build this from?

armconsumption@v1.2.0 generated from this swagger, there was no resourceType at that time. I will request a release-request as soon as possible

[joshk0]

Thank you!