Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockblob.StageBlock support stream #22777

Closed
jurejoy opened this issue Apr 23, 2024 · 5 comments
Closed

Blockblob.StageBlock support stream #22777

jurejoy opened this issue Apr 23, 2024 · 5 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files)

Comments

@jurejoy
Copy link

jurejoy commented Apr 23, 2024

Feature Request

When using Blockblob.StageBlock, could you clarify if below features is supported or any workaround?

  1. Is it possible for blockblob.stageblock support stream like uploadstream?
  2. In some scenario, copy files from some resource like s3 or some other objective storage, the response body has no io.ReadSeekerCloser, can you just provide io.Reader instead?
    image
@github-actions github-actions bot added Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service Attention This issue is responsible by Azure service team. Storage Storage Service (Queues, Blobs, Files) labels Apr 23, 2024
Copy link

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @xgithubtriage.

@jhendrixMSFT jhendrixMSFT removed the Service Attention This issue is responsible by Azure service team. label Apr 23, 2024
@github-actions github-actions bot added the needs-team-triage This issue needs the team to triage. label Apr 23, 2024
@jhendrixMSFT jhendrixMSFT removed the needs-team-triage This issue needs the team to triage. label Apr 23, 2024
@tanyasethi-msft
Copy link
Member

Hi @jurejoy, Thanks for your comment.

  1. You can use UploadStream instead.
    UploadStream internally does a parallel stageBlock and then does a put block list.

  2. StageBlock() internally calls PutBlock rest API, for which data needs to be stored beforehand, and cannot be fetched from the stream.
    So, if your response body has no io.ReadSeekerCloser, we recommend using UploadStream, which will use io.Reader.

@jurejoy
Copy link
Author

jurejoy commented Apr 23, 2024

Thanks for the explanation. Further question is, if I want to control the files blocks along with the blockID in "UploadStream", is it possible to do the same way like in StageBlock().

@jurejoy
Copy link
Author

jurejoy commented Apr 25, 2024

When use UploadStream, what is the max value for concurrency & block size, looks like the default is 1 and 1MB

@tanyasethi-msft
Copy link
Member

There is no max value for concurrency and block size for UploadStream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

No branches or pull requests

3 participants