Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azopenaiassistants] Function Tools Support #22767

Closed
pkrauss-prot opened this issue Apr 19, 2024 · 1 comment · Fixed by #22834
Closed

[azopenaiassistants] Function Tools Support #22767

pkrauss-prot opened this issue Apr 19, 2024 · 1 comment · Fixed by #22834
Assignees
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team OpenAI question The issue doesn't require a change to the product in order to be resolved. Most issues start as that

Comments

@pkrauss-prot
Copy link

Bug Report

  • import path of package in question.
    "github.com/Azure/azure-sdk-for-go/sdk/ai/azopenaiassistants"

  • SDK version
    "v0.1.0"

  • output of go version
    "go version go1.21.8 linux/amd64"

  • What happened?
    azopenaiassistants is obviously very new and being at a release v0 has no guarantees. However I noticed that the current implementation does not use the existing interface for RequiredActionClassification. Current implementation is using a concrete implementation that only returns Type and not the SubmitToolOutputsAction with both Type and SubmitToolOutputs.

  • What did you expect or want to happen?
    I was hoping that the interface was used so that i could return the SubmitToolOutputs to process function calls.

  • How can we reproduce it?

// this should be waiting in status "requires_action"
lastGetRunResp, err = client.GetRun(context.Background(), "a thread id", "a run id", nil)
// is concrete so you cannot swap it out for `SubmitToolOutputsAction`
lastGetRunResp.RequiredAction
  • Anything we should know about your environment.
    Nope pretty standard.
@github-actions github-actions bot added customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-triage This is a new issue that needs to be triaged to the appropriate team. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Apr 19, 2024
@jhendrixMSFT jhendrixMSFT added OpenAI and removed needs-triage This is a new issue that needs to be triaged to the appropriate team. labels Apr 19, 2024
@github-actions github-actions bot added the needs-team-attention This issue needs attention from Azure service team or SDK team label Apr 19, 2024
@richardpark-msft
Copy link
Member

Looking at this. It looks like something didn't quite generate properly there since, as you noted, the RequiredAction model did get generated.

richardpark-msft added a commit that referenced this issue May 4, 2024
…s deserialized incorrectly (#22834)

Fixing bug where the ThreadRun.RequiredAction was deserialized incorrectly, making it impossible to actually resubmit a tool output.

Fixes #22767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team OpenAI question The issue doesn't require a change to the product in order to be resolved. Most issues start as that
Projects
None yet
3 participants