Why should this be hardcoded to Https?

[yanivsag]

azure-sdk-for-go/sdk/storage/azblob/container/client.go

Line 351 in bac2559

Protocol: sas.ProtocolHTTPS,

I suggest basing this on the URL, since it makes the method unusable for users of the azurite storage emulator.

[vibhansa-msft]

Hi @yanivsag
GetSasURL is just a helper method to generate SAS from SharedKey or UserDelegationKey. We have used 'https' as default, but that does not restrict you in anyway. You can create your own BlobSignatureValue in context of your application and generate a SAS which allows both http and https.

[yanivsag]

True, but from a user of the lib that opens the client with a connection string, i think it's inconvenient to extract the access key from the connection string while the container Client module already has this code available.
Also, it changed behavior of previous versions (i discovered it while migrating code that used v0.3.0 of azblob)

[vibhansa-msft]

0.3.0 was not a GA release. For the security reasons HTTP was not allowed in certain auth flows. By default its HTTPs now and for HTTP you need to create SAS by calling respective SDK apis and not through GetSASToken(). For now you can use this as a workaround, let me discuss this with team and see what shall be the correct way to handle this.

[yanivsag]

got it, thanks!

[vibhansa-msft]

This has been fixed as part of #22704