Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support UserDelegationCredential in BlobSASSignatureValues.NewSASQueryParameters and on ServiceClient #18976

Closed
bmorck opened this issue Aug 30, 2022 · 3 comments
Closed

Support UserDelegationCredential in BlobSASSignatureValues.NewSASQueryParameters and on ServiceClient #18976

bmorck opened this issue Aug 30, 2022 · 3 comments
Assignees
@siminsavani-msft
Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. needs-team-attention This issue needs attention from Azure service team or SDK team Storage Storage Service (Queues, Blobs, Files)
Milestone
2022-10

Comments

@bmorck
Copy link

bmorck commented Aug 30, 2022 •
edited

Feature Request

Within the previous azblob SDK, there was support for a UserDelegationCredential. This credential could be supplied to BlobSASSignatureValues.NewSASQueryParameters and is returned from ServiceURL.GetUserDelegationCredential or created using NewUserDelegationCredential by supplying a UserDelegationKey.

Currently, within the new azblob SDK the UserDelegationKey is supported but is not used in any methods. Additionally there is a comment on BlobSASSignatureValues.NewSASQueryParameters that indicated that UserDelegationCredential can be used, but it only accepts a SharedKeyCredential

NewSASQueryParameters uses an account's StorageAccountCredential to sign this signature values to produce the proper SAS query parameters. See: StorageAccountCredential. Compatible with both UserDelegationCredential and SharedKeyCredential

Due to this, we would like the UserDelegationCredential to be supported on the ServiceClient (as it was supported on the ServiceURL in the previous azblob SDK, and in BlobSASSignatureValues.NewSASQueryParameters.

Currently we are generating User Delegation Key using the REST API and manually generating the User Delegation SAS using the User Delegation Key returned from the API call. This is a verbose method of constructing the SAS and using the SDK would allow for a simpler and more readable method of working with User Delegation SAS.
@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Aug 30, 2022
@ghost
Copy link

ghost commented Aug 30, 2022

Hi @bmorck. Thank you for your feedback and we will look into it soon. Meanwhile, feel free to share your experience using the Azure SDK in this survey.

@ghost ghost added customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Aug 30, 2022
@bmorck bmorck mentioned this issue Aug 30, 2022
Closed
@RickWinter RickWinter added Storage Storage Service (Queues, Blobs, Files) Service This issue points to a problem in the service. labels Sep 1, 2022
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Sep 1, 2022
@RickWinter RickWinter added the Previous Versions Work related to track1 and track1.5 SDKs label Sep 1, 2022
@ghost ghost added the needs-team-attention This issue needs attention from Azure service team or SDK team label Sep 1, 2022
@RickWinter RickWinter added this to the 2022-10 milestone Sep 1, 2022
@jhendrixMSFT jhendrixMSFT added Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that Service This issue points to a problem in the service. Previous Versions Work related to track1 and track1.5 SDKs labels Sep 16, 2022
@jhendrixMSFT jhendrixMSFT mentioned this issue Sep 16, 2022
Closed
5 tasks
@siminsavani-msft siminsavani-msft mentioned this issue Sep 19, 2022
Merged
5 tasks
@zezha-msft
Copy link

Thanks for the feature request, it is being actively worked on.

@siminsavani-msft
Copy link
Member

Hi @bmorck ! We have released the User Delegation feature (https://github.com/Azure/azure-sdk-for-go/releases/tag/sdk%2Fstorage%2Fazblob%2Fv0.5.0) today. Please give it a try and let us know if you have any questions!

Examples can be found here:

azure-sdk-for-go/sdk/storage/azblob/service/examples_test.go

Line 286 in 7a3989f

func Example_service_Client_NewClientWithUserDelegationCredential() {

@malt3 malt3 mentioned this issue Oct 14, 2022
Merged
1 task
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@siminsavani-msft siminsavani-msft

Labels
Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. feature-request This issue requires a new behavior in the product in order be resolved. needs-team-attention This issue needs attention from Azure service team or SDK team Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
2022-10
Development

No branches or pull requests
5 participants
@RickWinter @jhendrixMSFT @zezha-msft @bmorck @siminsavani-msft