Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename azkeys.ReleaseKeyOptions.Enc to .Algorithm #18170

Merged
merged 8 commits into from May 25, 2022
Merged

Rename azkeys.ReleaseKeyOptions.Enc to .Algorithm #18170

merged 8 commits into from May 25, 2022

Conversation

chlowell
Copy link
Contributor

Algorithm is clearer and the name for this option in other languages.

@chlowell chlowell added KeyVault Client This issue points to a problem in the data-plane of the library. labels May 18, 2022
@chlowell
Copy link
Contributor Author

I found a few more breaking changes we should make in azkeys. Converting this to a draft while I add them here.

@chlowell chlowell marked this pull request as draft May 18, 2022 23:47
@chlowell
Copy link
Contributor Author

The further breaking changes are:

  • Make model field types consistently pointers to things e.g. Tags map[string]string -> map[string]*string
  • Delete redundant Tags and Managed fields on ImportKeyOptions, DeletedKeyItem (e.g. ImportKeyOptions.Properties already has these fields)
  • Use the existing Operation enum type instead of string

@chlowell chlowell marked this pull request as ready for review May 25, 2022 00:45
@chlowell chlowell merged commit 3264ce3 into Azure:main May 25, 2022
@chlowell chlowell deleted the enc branch May 25, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths heaths approved these changes

@jhendrixMSFT jhendrixMSFT jhendrixMSFT approved these changes

@JeffreyRichter JeffreyRichter Awaiting requested review from JeffreyRichter

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chlowell @heaths @jhendrixMSFT