Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add auto release flag for mgmt. plane release #17356

Merged
merged 5 commits into from Mar 29, 2022

Conversation

tadelesh
Copy link
Member

@tadelesh tadelesh commented Mar 23, 2022

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

Resolve #17351

@tadelesh
Copy link
Member Author

@benbp
Copy link
Member

benbp commented Mar 23, 2022

Looks good to me but holding approval until we reach a consensus on #17356 (comment)

@tadelesh
Copy link
Member Author

@seankane-msft could you have a review as I exclude the doc validation for the eng/tools folder?

Copy link
Member

@seankane-msft seankane-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, allowing Wes and Ben to make the final call

@RickWinter
Copy link
Member

@benbp @weshaggard What does AutoRelease do? Does that mean a human never clicks the final approval? Do we have sufficient permissions and checks in place to prevent unintentional releases?

Copy link
Member

@RickWinter RickWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to ensure proper safeguards are in place to prevent unintentional triggers and resulting releases.

@tadelesh
Copy link
Member Author

tadelesh commented Mar 25, 2022

@benbp @weshaggard What does AutoRelease do? Does that mean a human never clicks the final approval? Do we have sufficient permissions and checks in place to prevent unintentional releases?

@RickWinter The word might be a little bit confusing. Actually Include Release might be more accurate. When it is set to true, the release pipeline will be trigger. Then a pre-release job will check if there is a new version need to be released. If true, the release job will do the changelog check, etc., then WAITING FOR APPROVAL for the truly release. This is used for auto trigger, not for approval the truly release as we want to just do one final approval instead of too many manual work (find pipeline, manual trigger, waiting result, approve the release) for mgmt. plane release. The pipeline has working fine for a long time (Here is the original PR I added it) until the latest change of the condition. Ben and I are trying to fix it with introducing a new flag.

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. However I defer to @RickWinter on whether or not there are other considerations.

@tadelesh tadelesh merged commit 38ec428 into Azure:main Mar 29, 2022
@tadelesh tadelesh deleted the update_release_pipeline branch March 30, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore auto-release stage behavior for mgmt plane pipelines
5 participants