Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nil pointer exception if nil options passed in ListBlobsFlat #17335

Closed
andrewbaxter opened this issue Mar 21, 2022 · 5 comments
Closed

Nil pointer exception if nil options passed in ListBlobsFlat #17335

andrewbaxter opened this issue Mar 21, 2022 · 5 comments
Assignees
@zezha-msft @mohsha-msft
Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team Storage Storage Service (Queues, Blobs, Files)

Comments

@andrewbaxter
Copy link

Bug Report

On azblob v0.3.0

The code was changed to reuse the passed in options for subsequent pagination requests here: #16992

However, if nil is passed in for options this causes a panic when the advancer tries to set the new marker. This conflicts with conventions elsewhere in the code that allow nil values to be passed in (and previously a nil value was also accepted here).
@ghost ghost added needs-triage This is a new issue that needs to be triaged to the appropriate team. customer-reported Issues that are reported by GitHub users external to the Azure organization. question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 21, 2022
@jhendrixMSFT jhendrixMSFT added the Storage Storage Service (Queues, Blobs, Files) label Mar 21, 2022
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Mar 21, 2022
@jhendrixMSFT jhendrixMSFT added Client This issue points to a problem in the data-plane of the library. and removed question The issue doesn't require a change to the product in order to be resolved. Most issues start as that labels Mar 21, 2022
@ghost ghost added the needs-team-attention This issue needs attention from Azure service team or SDK team label Mar 21, 2022
@zezha-msft
Copy link

Thanks for reaching out!

We will take a look and make a fix in the next release.

@zezha-msft zezha-msft added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Mar 23, 2022
@bcvanmeurs
Copy link

I can confirm I encountered the same bug.

@mohsha-msft
Copy link
Contributor

Hey @andrewbaxter , @bcvanmeurs ,

Thanks for reaching out!
I've fixed the issue and I'll ship it in the next release.

@bcvanmeurs
Copy link

bcvanmeurs commented Mar 24, 2022 •
edited

@mohsha-msft Great, thanks!

@mohsha-msft
Copy link
Contributor

Hey @andrewbaxter @bcvanmeurs ,

azblob v0.4.0 is now publically available. I have fixed the issue here.

Please reach out and reopen the issue if it still persists.

Thanks a lot for your feedbacks!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zezha-msft zezha-msft

@mohsha-msft mohsha-msft

Labels
bug This issue requires a change to an existing behavior in the product in order to be resolved. Client This issue points to a problem in the data-plane of the library. customer-reported Issues that are reported by GitHub users external to the Azure organization. needs-team-attention This issue needs attention from Azure service team or SDK team Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@andrewbaxter @bcvanmeurs @jhendrixMSFT @zezha-msft @mohsha-msft