Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azblob constructors should return clients by reference #16972

Closed
chlowell opened this issue Feb 3, 2022 · 1 comment
Closed

azblob constructors should return clients by reference #16972

chlowell opened this issue Feb 3, 2022 · 1 comment
Assignees
@zezha-msft
Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)

Comments

@chlowell
Copy link
Contributor

chlowell commented Feb 3, 2022

That is to say, they should return a pointer to a client instance. They currently return an instance by value. For example:

azure-sdk-for-go/sdk/storage/azblob/zc_blob_client.go

Line 22 in 63f64be

func NewBlobClient(blobURL string, cred azcore.TokenCredential, options *ClientOptions) (BlobClient, error) {

@chlowell chlowell added Storage Storage Service (Queues, Blobs, Files) Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. labels Feb 3, 2022
@jhendrixMSFT jhendrixMSFT mentioned this issue Apr 15, 2022
Closed
@mohsha-msft
Copy link
Contributor

Hey @chlowell ,

azblob v0.4.0 is now publically available. I have made the necessary changes.

Thanks a lot for your feedbacks!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zezha-msft zezha-msft

Labels
Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chlowell @zezha-msft @mohsha-msft