Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azservicebus] AdminClient can now create topics and subscriptions #16044

Merged
merged 4 commits into from
Nov 4, 2021

Conversation

richardpark-msft
Copy link
Member

@richardpark-msft richardpark-msft commented Nov 1, 2021

Adds in support for creating topics and subscriptions using the AdminClient.

There were also some bits of feedback cleaned up in here - all the request/response objects should be proper per our guidelines.

Fixes #15090

- Adding in proper request/response objects, as specified by guidelines.
- Removing old _manager structs, in favor of the new AdminClient.
- Adding in tests for handling low privilege failures
@richardpark-msft richardpark-msft added Service Bus Client This issue points to a problem in the data-plane of the library. labels Nov 1, 2021
@richardpark-msft
Copy link
Member Author

/azp run go - azservicebus

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft
Copy link
Member Author

/azp run go - azservicebus

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@check-enforcer
Copy link

check-enforcer bot commented Nov 3, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run go - [service] - ci

@richardpark-msft
Copy link
Member Author

/azp run go - azservicebus

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@richardpark-msft richardpark-msft merged commit 14e0cee into Azure:main Nov 4, 2021
@richardpark-msft richardpark-msft deleted the atom-topics branch November 4, 2021 00:19
jhendrixMSFT pushed a commit to jhendrixMSFT/azure-sdk-for-go that referenced this pull request Jan 12, 2022
…zure#16044)

Adding in ability to create/update/delete Topics and Subscriptions.
- Adding in proper request/response objects, as specified by guidelines.
- Adding in tests for handling low privilege failures
- (internal) Removing old _manager structs, in favor of the new AdminClient.

Fixes Azure#15090, Azure#15801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[service-bus] ServiceBusAdministrationClient
2 participants