Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't overwrite final get URI with empty string #14678

Merged
merged 2 commits into from
May 19, 2021
Merged

Don't overwrite final get URI with empty string #14678

merged 2 commits into from
May 19, 2021

Conversation

jhendrixMSFT
Copy link
Member

If the success response doesn't return a final get URI used the value
that was previously calculated.

  • The purpose of this PR is explained in this or a referenced issue.
  • The PR does not update generated files.
  • Tests are included and/or updated for code changes.
  • Updates to CHANGELOG.md are included.
  • MIT license headers are included in each file.

@jhendrixMSFT
Don't overwrite final get URI with empty string
d3b08f7 
If the success response doesn't return a final get URI used the value
that was previously calculated.
@jhendrixMSFT
Copy link
Member Author

Fixes #14665

catalinaperalta
catalinaperalta approved these changes May 19, 2021
View reviewed changes
Copy link
Member

@catalinaperalta catalinaperalta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhendrixMSFT jhendrixMSFT merged commit 57de692 into Azure:master May 19, 2021
@jhendrixMSFT jhendrixMSFT deleted the armcore_final_get branch May 19, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catalinaperalta catalinaperalta catalinaperalta approved these changes

@ArcturusZhang ArcturusZhang ArcturusZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhendrixMSFT @catalinaperalta @ArcturusZhang