Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide what to do with AZ_FUNC_TABLE_INFO_CACHE_TIMEOUT_MINUTES #895

Open
Charles-Gagnon opened this issue Jul 28, 2023 · 0 comments
Open

Comments

@Charles-Gagnon
Copy link
Contributor

This was added in #395 but then the test it was added for was later remove d in #560, so it's not currently being used. And it's not documented anywhere for customers to be able to use themselves.

Questions we should ask:

  • Do we still want/need this? It happened to be useful in Can't update a row in table with IDENTITY as primary key #891, but that's a bug and not something we normally intend
  • Do we need this caching at all? Can we refactor the bindings to get all the column info for a table and be fine with that never changing for the lifetime of the function? (we already say that changes to the table while a function is running may have unexpected behavior)

If we do keep it, we should consider moving the parsing logic out of the UpsertRowsAsync method. We only need to calculate the value once at startup - so calculating it each time an insert is done is just wasted effort.

@Charles-Gagnon Charles-Gagnon changed the title Decide what to do with Decide what to do with AZ_FUNC_TABLE_INFO_CACHE_TIMEOUT_MINUTES Jul 28, 2023
@lucyzhang929 lucyzhang929 added this to the Post GA milestone Aug 1, 2023
@MaddyDev MaddyDev added P2 and removed bug Something isn't working labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants